Merged
Conversation
Goober5000
added
the
cleanup
Goober5000
force-pushed
the
const_char_lookup
branch
2 times, most recently
from
9162878 to
cf7a265
Compare
wookieejedi
approved these changes
Mar 20, 2026
Member
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
Looks good but may want to consider holding off on merging until FRED SEXP refactor is in if it touches some of the same files?
Contributor
I have reviewed this PR. The changes in sexp_tree files are already matched in #7301 's |
Contributor
Author
|
Good plan. I'll remove the sexp_tree changes from this PR. |
1. Change `ai_profile_lookup` and `multi_xfer_lookup` to use `const char *`, since all the other lookup functions do 2. Remove several unneeded `const_cast`s, some of which are now made possible by the non-const `data()` overload in C++17 3. Change `campaign_link` to use `const char*` 4. Use better string management in `test::FSTestFixture::init_cmdline()`
Goober5000
force-pushed
the
const_char_lookup
branch
from
cf7a265 to
a47d34c
Compare
Member
|
Updated looks good so feel free to merge when you're ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ai_profile_lookupandmulti_xfer_lookupto useconst char *, since all the other lookup functions doconst_casts, some of which are now made possible by the non-constdata()overload in C++17campaign_linkto useconst char*test::FSTestFixture::init_cmdline()