Skip to content

Fix typography docs page crashing with React error #130#1111

Merged
bert-e merged 1 commit into
development/1.0from
bugfix/fix-typography-docs-import
May 20, 2026
Merged

Fix typography docs page crashing with React error #130#1111
bert-e merged 1 commit into
development/1.0from
bugfix/fix-typography-docs-import

Conversation

@Cuervino
Copy link
Copy Markdown
Contributor

@Cuervino Cuervino commented May 20, 2026

Problem

The Typography docs page (Style/Typography) was crashing with a minified React error #130 (element type is invalid — expected a string or class/function but got undefined).

The root cause: typography.mdx was importing Meta from @storybook/addon-docs (the package root), which does not re-export Meta in Storybook 10. The component resolved as undefined at runtime, causing the render to fail.

Fix

Change the import to the correct subpath:

- import { Meta } from "@storybook/addon-docs";
+ import { Meta } from '@storybook/addon-docs/blocks';

This is consistent with every other MDX file in the stories/ directory, which already use @storybook/addon-docs/blocks.

Verification

Confirmed locally: the Typography page renders correctly after the fix.

Meta was imported from @storybook/addon-docs instead of @storybook/addon-docs/blocks, causing it to resolve as undefined at runtime.
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 20, 2026

Hello cuervino,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 20, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@Cuervino Cuervino requested a review from a team May 20, 2026 14:49
@JBWatenbergScality
Copy link
Copy Markdown
Contributor

/bypass_author_approval

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 20, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue None.

Goodbye cuervino.

The following options are set: bypass_author_approval

@bert-e bert-e merged commit f795de5 into development/1.0 May 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants