Add build-storybook workflow to catch Storybook build failures pre-merge#1087
Open
JBWatenbergScality wants to merge 1 commit into
Open
Add build-storybook workflow to catch Storybook build failures pre-merge#1087JBWatenbergScality wants to merge 1 commit into
JBWatenbergScality wants to merge 1 commit into
Conversation
The Deploy Storybook workflow only runs on push to development/1.0, so any regression that breaks `npm run build-storybook` (bad JSDoc in stories, broken MDX, etc.) is only discovered after the merge lands. This adds a build-only job that runs on feature/w/* branch pushes and PRs against development/*, so bert-e and reviewers see the failure before merge. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Hello jbwatenbergscality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/storybook-build.ymlthat runsnpm run build-storybookon feature/w/* branch pushes and on PRs againstdevelopment/*,stabilization/*, andhotfix/*.Motivation
The existing
Deploy Storybookworkflow (github-pages.yml) is triggered bypushtodevelopment/1.0, i.e. after the merge has already landed.basic testsonly runstest+lint, neverbuild-storybook. As a result, any regression that breaks the Storybook build slips through bert-e and is only discovered post-merge on the deploy job — see the failingdeployrun on #1061 (run 24741409960) which started 6 seconds after bert-e merged.This workflow runs the same
build-storybookstep pre-merge so bert-e and reviewers see the failure before merge.Trigger design
pushon the same branch patterns astests.yaml(user/**,feature/**,improvement/**,bugfix/**,w/**,q/**,hotfix/**,dependabot/**) — matters for bert-e, which evaluates build status on thew/*integration branch it creates.pull_requestondevelopment/*,stabilization/*,hotfix/*— covers forks / direct PRs.workflow_dispatch— manual retries.Deploy stays in
github-pages.ymlso forked PRs cannot push to gh-pages.Test plan
build-storybookon this PR and passes.build-storybookcheck appears in the PR status rollup.🤖 Generated with Claude Code