Skip to content

Add build-storybook workflow to catch Storybook build failures pre-merge#1087

Open
JBWatenbergScality wants to merge 1 commit into
development/1.0from
improvement/build-storybook-on-pr
Open

Add build-storybook workflow to catch Storybook build failures pre-merge#1087
JBWatenbergScality wants to merge 1 commit into
development/1.0from
improvement/build-storybook-on-pr

Conversation

@JBWatenbergScality
Copy link
Copy Markdown
Contributor

Summary

  • Add .github/workflows/storybook-build.yml that runs npm run build-storybook on feature/w/* branch pushes and on PRs against development/*, stabilization/*, and hotfix/*.
  • No deploy, no gh-pages push, no token — build-only.

Motivation

The existing Deploy Storybook workflow (github-pages.yml) is triggered by push to development/1.0, i.e. after the merge has already landed. basic tests only runs test + lint, never build-storybook. As a result, any regression that breaks the Storybook build slips through bert-e and is only discovered post-merge on the deploy job — see the failing deploy run on #1061 (run 24741409960) which started 6 seconds after bert-e merged.

This workflow runs the same build-storybook step pre-merge so bert-e and reviewers see the failure before merge.

Trigger design

  • push on the same branch patterns as tests.yaml (user/**, feature/**, improvement/**, bugfix/**, w/**, q/**, hotfix/**, dependabot/**) — matters for bert-e, which evaluates build status on the w/* integration branch it creates.
  • pull_request on development/*, stabilization/*, hotfix/* — covers forks / direct PRs.
  • workflow_dispatch — manual retries.

Deploy stays in github-pages.yml so forked PRs cannot push to gh-pages.

Test plan

  • CI runs build-storybook on this PR and passes.
  • Verify a new build-storybook check appears in the PR status rollup.
  • Optional: intentionally break a story in a scratch branch and confirm the new job fails.

🤖 Generated with Claude Code

The Deploy Storybook workflow only runs on push to development/1.0, so any
regression that breaks `npm run build-storybook` (bad JSDoc in stories,
broken MDX, etc.) is only discovered after the merge lands. This adds a
build-only job that runs on feature/w/* branch pushes and PRs against
development/*, so bert-e and reviewers see the failure before merge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 22, 2026

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 22, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants