-
Notifications
You must be signed in to change notification settings - Fork 11
[DE-6999] Enable image deduplication within nucleus sdk #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b8ff516
Enable deduplication in nucleus sdk
edwinpav 436fbaf
Lint fixes
edwinpav 0a1c8d2
Fix import order
edwinpav 4b2a1d4
Add tests for deduplication sdk
edwinpav 6545d02
Fix isort import formatting errors
edwinpav 019a31a
Add fixture for image dataset specifically for dedup
edwinpav ed67d5b
Fix image dataset creation syntax
edwinpav 6330be2
Create image dataset syncrhonously
edwinpav 6d6a0ce
Make dataset_with_duplicates fixture sync
edwinpav 9ec043a
Add dedup test for scene made with video url
edwinpav 538c864
Document difference between deduplicate and deduplicate_by_ids better…
edwinpav dc3f61c
Add tests to cover all ingestion forms
edwinpav 2753603
Refactor tests to use DEDUP_DEFAULT_TEST_THRESHOLD constant
edwinpav 8309469
Use try-finally for dataset creation and deletion
edwinpav 5a0e896
Make edge case test docstrings more detailed
edwinpav 14c751f
Remove deprecated video sync upload tests
edwinpav 4861691
Update test_jobs to be deterministic
edwinpav 07a87a7
Split jobs tests into listing and retrieval separately
edwinpav 4cfc129
Fix docstring typo
edwinpav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| from dataclasses import dataclass | ||
| from typing import List | ||
|
|
||
|
|
||
| @dataclass | ||
| class DeduplicationStats: | ||
| threshold: int | ||
| original_count: int | ||
| deduplicated_count: int | ||
|
|
||
|
|
||
| @dataclass | ||
| class DeduplicationResult: | ||
| unique_item_ids: List[str] # Internal dataset item IDs | ||
| unique_reference_ids: List[str] # User-defined reference IDs | ||
| stats: DeduplicationStats |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make it clearer in the docstring what the difference is between this and the following endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, will do