Skip to content

fix(conga): fix calibration and room coordinates scaling - bump to 0.3.2#77

Merged
sca075 merged 1 commit intomainfrom
dev
Mar 15, 2026
Merged

fix(conga): fix calibration and room coordinates scaling - bump to 0.3.2#77
sca075 merged 1 commit intomainfrom
dev

Conversation

@sca075
Copy link
Copy Markdown
Owner

@sca075 sca075 commented Mar 15, 2026

  • Override get_vacuum_points to divide crop_area by CONGA_SCALE,
    restoring calibration points to original vacuum coordinate space.
  • Override async_get_rooms_attributes to divide room outline and
    centre x/y by CONGA_SCALE, restoring room data to vacuum space.
  • Bump version to 0.3.2.

Summary by CodeRabbit

  • Bug Fixes

    • Corrected coordinate scaling for room attributes in map parsing to ensure accurate spatial positioning.
  • Chores

    • Version bumped to 0.3.2.

- Override get_vacuum_points to divide crop_area by CONGA_SCALE,
  restoring calibration points to original vacuum coordinate space.
- Override async_get_rooms_attributes to divide room outline and
  centre x/y by CONGA_SCALE, restoring room data to vacuum space.
- Bump version to 0.3.2.
@sca075 sca075 self-assigned this Mar 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 83ed8c34-d72b-4fc7-a422-d958f31d8920

📥 Commits

Reviewing files that changed from the base of the PR and between b22ac77 and abdeee9.

📒 Files selected for processing (3)
  • SCR/valetudo_map_parser/__init__.py
  • SCR/valetudo_map_parser/conga_handler.py
  • pyproject.toml

📝 Walkthrough

Walkthrough

Version number updated to 0.3.2 across package metadata and module docstring. A new async method async_get_rooms_attributes added to CongaMapImageHandler that retrieves room attributes from the parent class and scales coordinates back by dividing by CONGA_SCALE.

Changes

Cohort / File(s) Summary
Version Bumps
SCR/valetudo_map_parser/__init__.py, pyproject.toml
Metadata version updated from 0.3.1 to 0.3.2.
Coordinate Scaling Reversal
SCR/valetudo_map_parser/conga_handler.py
New async_get_rooms_attributes() method added to CongaMapImageHandler that retrieves room attributes and reverses CONGA_SCALE coordinate scaling by dividing outline and room x/y coordinates by the scale factor.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • PR #74: Adds async_get_rooms_attributes to CongaMapImageHandler that directly reverses the CONGA_SCALE-based coordinate scaling previously introduced.
  • PR #76: Modifies CongaMapImageHandler with coordinate transformation methods that involve CONGA_SCALE adjustments.
  • PR #53: Complements the current addition with usage of async_get_rooms_attributes in BaseHandler's shared data update logic.

Suggested labels

enhancement

Poem

🐰 Coordinates dance and twist about,
Scaled back down without a doubt,
Conga's handler now so spry,
Version bumped toward the sky,
Enhancement hops right by!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: fixing CONGA coordinate scaling issues and bumping the version to 0.3.2, which directly aligns with the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sca075 sca075 merged commit 7664183 into main Mar 15, 2026
3 checks passed
sca075 added a commit that referenced this pull request Mar 15, 2026
…3.2 (#77) (#78)

- Override get_vacuum_points to divide crop_area by CONGA_SCALE,
  restoring calibration points to original vacuum coordinate space.
- Override async_get_rooms_attributes to divide room outline and
  centre x/y by CONGA_SCALE, restoring room data to vacuum space.
- Bump version to 0.3.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant