hostkeys: Properly set name of created sshkey objects#440
Open
supertassu wants to merge 1 commit intosaz:masterfrom
Open
hostkeys: Properly set name of created sshkey objects#440supertassu wants to merge 1 commit intosaz:masterfrom
supertassu wants to merge 1 commit intosaz:masterfrom
Conversation
By default, the sshkey resource assumes the resource title is a hostname that should end up in the known hosts file, so with the current setup hosts like some.fdqn.example_ed25519 are ending up in there which is wrong and messes up tab completion and similar. This commit removes those incorrect names by updating the resource to override the name attribute to the host FQDN instead of relying on the default resource title and setting the host FQDN as an alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
By default, the sshkey resource assumes the resource title is a hostname that should end up in the known hosts file, so with the current setup hosts like
some.fdqn.example_ed25519are ending up in there which is wrong and messes up tab completion and similar.This PR removes those incorrect names by updating the resource to override the name attribute to the host FQDN instead of relying on the default resource title and setting the host FQDN as an alias.
This Pull Request (PR) fixes the following issues
n/a