Skip to content

Improve arc-flattening performance #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sameer merged 5 commits into from
Mar 11, 2026
Merged

Improve arc-flattening performance #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ccc12f
Revert "Use golden section search to calculate max deviation in arc f…
sameer Mar 11, 2026
d81d1f7
Add a Bezier tolerance test
sameer Mar 11, 2026
92dec90
Swap to inflection points
sameer Mar 11, 2026
7e95186
Simplify arc_from_endpoints_and_tangents calculation
sameer Mar 11, 2026
e145937
Use geometric distance to arc instead of equal t sampling
sameer Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/lib.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ jobs:
with:
components: clippy
- uses: Swatinem/rust-cache@v2
- name: Install dependencies
run: sudo apt-get update && sudo apt-get install -y libcairo2-dev
- name: Fmt
run: cargo +nightly-${{ steps.stable-date.outputs.date }} fmt --check -p svg2gcode
- name: Clippy
Expand All @@ -48,8 +46,6 @@ jobs:
with:
toolchain: nightly
components: llvm-tools-preview
- name: Install dependencies
run: sudo apt-get update && sudo apt-get install -y libcairo2-dev
- run: cargo install grcov
- run: cargo build -p svg2gcode
env:
Expand Down
127 changes: 2 additions & 125 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions lib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,5 @@ optional = true
version = "0.1"

[dev-dependencies]
cairo-rs = { version = "0.22", default-features = false, features = [
"svg",
"v1_16",
] }
serde_json.workspace = true
pretty_assertions = "1.4.1"
Loading