Skip to content

Zizmor fixes#1037

Open
Caritajoe18 wants to merge 5 commits intorust-lang:masterfrom
Caritajoe18:zizmor-fixes
Open

Zizmor fixes#1037
Caritajoe18 wants to merge 5 commits intorust-lang:masterfrom
Caritajoe18:zizmor-fixes

Conversation

@Caritajoe18
Copy link
Copy Markdown

Fix Zizmor security findings in GitHub Actions workflows

deploy.yml changes:

  • Pin actions to commit hashes
  • Add persist-credentials: false to checkout
  • Add explicit permissions blocks with comments:
    • workflow: permissions: {}
    • deploy job: pages: write, id-token: write
  • Add job names
  • Add concurrency limits (high severity):
    • group: pages, cancel-in-progress: false

test.yml changes:

  • Pin actions/checkout@v4
  • Add persist-credentials: false
  • Add permissions: contents: read
  • Add concurrency limits with cancel-in-progress: true

Add Zizmor security audit workflow to prevent Zizmor issues from happening again.

Security impact: Eliminates risks of:

  • Compromised action tags executing malicious code
  • Leaked GitHub tokens from credential persistence
  • Overly broad workflow permissions enabling privilege escalation
  • Concurrent workflow runs are causing race conditions or resource exhaustion.
  • CI/CD regressions

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 15, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Fallback group: @Mark-Simulacrum, internal-sites
  • @Mark-Simulacrum, internal-sites expanded to Mark-Simulacrum, Urgau, ehuss, jieyouxu
  • Random selection from Mark-Simulacrum, Urgau, ehuss, jieyouxu

@jieyouxu
Copy link
Copy Markdown
Member

@rustbot reroll

@rustbot rustbot assigned Mark-Simulacrum and unassigned jieyouxu Apr 15, 2026
@marcoieni
Copy link
Copy Markdown
Member

r? me

@rustbot rustbot assigned marcoieni and unassigned Mark-Simulacrum Apr 15, 2026
Comment thread .github/workflows/deploy.yml Outdated
Comment thread .github/workflows/deploy.yml Outdated
run: ./mdbook build
- name: Upload artifact
uses: actions/upload-pages-artifact@v4
uses: actions/upload-pages-artifact@56afc609e74202658d3ffba0e8f6dda462b719fa # v3
Copy link
Copy Markdown
Member

@marcoieni marcoieni Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also downgraded the version here. Please review the PR yourself before asking others to review it 🙏

View changes since the review

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated to the action versions to latest releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants