fix: Fix param inlayHints on empty expr and comma#21926
Merged
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom Apr 3, 2026
Merged
fix: Fix param inlayHints on empty expr and comma#21926ChayimFriedman2 merged 2 commits intorust-lang:masterfrom
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
changed the title
ChayimFriedman2
approved these changes
Apr 3, 2026
| } | ||
|
|
||
| /// Comma separated args, argument may be empty | ||
| pub fn split_args(args: &ast::ArgList) -> impl Iterator<Item = Option<ast::Expr>> { |
Contributor
There was a problem hiding this comment.
I prefer this to be a method in syntax.
Contributor
There was a problem hiding this comment.
Also a more descriptive name, like args_maybe_empty().
Member
Author
There was a problem hiding this comment.
I don't think we should accept &SyntaxNode because he only handles ArgList
Oh, it's syntax crate
Example
---
```rust
pub fn test(a: i32, b: i32, c: i32) {}
fn main() {
test(, 2,);
test(, , 3);
}
```
**Before this PR**
```rust
test(, 2,);
//^ a
test(, , 3);
//^ a
```
**After this PR**
```rust
test(, 2,);
//^ b
test(, , 3);
//^ c
```
A4-Tacks
force-pushed
the
inlayhint-empty-arg
branch
from
6422bd2 to
dff1339
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ChayimFriedman2
approved these changes
Apr 3, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
After this PR