fix: unconditionally pass --include-ignored for test runnables#21921
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom Apr 3, 2026
Merged
fix: unconditionally pass --include-ignored for test runnables#21921ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Apr 1, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
S-waiting-on-author
Amit5601
force-pushed
the
fix-test-ignored-flag
branch
from
034bd25 to
197aa00
Compare
rustbot
removed
S-waiting-on-author
ChayimFriedman2
approved these changes
Apr 2, 2026
|
|
||
| match kind { | ||
| RunnableKind::Test { test_id, attr } => { | ||
| RunnableKind::Test { test_id, .. } => { |
Contributor
There was a problem hiding this comment.
Suggested change
| RunnableKind::Test { test_id, .. } => { | |
| RunnableKind::Test { test_id } => { |
Contributor
|
Please squash. |
Amit5601
force-pushed
the
fix-test-ignored-flag
branch
from
b5b6231 to
b0ca516
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
You reverted recent PRs with your latest rebase. Please revert that ( |
Amit5601
force-pushed
the
fix-test-ignored-flag
branch
from
b0ca516 to
b5b6231
Compare
This comment has been minimized.
This comment has been minimized.
Amit5601
force-pushed
the
fix-test-ignored-flag
branch
from
b5b6231 to
1b7c1c3
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Amit5601
force-pushed
the
fix-test-ignored-flag
branch
from
1b7c1c3 to
41596b6
Compare
Contributor
Author
|
@ChayimFriedman2 rebased and squashed correctly, the accidental reverts from the last push are gone. |
ChayimFriedman2
approved these changes
Apr 3, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21889
This replaces the conditional --ignored flag with an unconditional --include-ignored flag for test runnables.