Skip to content

Add new HelperInstr sort#748

Merged
automergerpr-permission-manager[bot] merged 3 commits intomasterfrom
anvacaru/helper-sort
Mar 23, 2026
Merged

Add new HelperInstr sort#748
automergerpr-permission-manager[bot] merged 3 commits intomasterfrom
anvacaru/helper-sort

Conversation

@anvacaru
Copy link
Copy Markdown
Contributor

  • Introduced a new HelperInstr sort in WASM-INTERNAL-SYNTAX for existing auxiliary Instr productions.
  • Moved all internal execution-phase instruction productions out of into HelperInstr subsort:
    • covering control flow (#block, #br, #if, #loop),
    • variable access (#local.*, #global.*),
    • table operations (#table.*, #tableGet, #tableFill),
    • reference instructions (#ref.is_null, #ref.func),
    • call helpers (#call, #callIndirect),
    • memory stepping helpers (grow, fill, copy, fillTrap, copyTrap),
    • local initialization (init_local, init_locals).

@anvacaru anvacaru marked this pull request as ready for review March 18, 2026 12:11
@anvacaru anvacaru requested a review from bbyalcinkaya March 18, 2026 12:11
Copy link
Copy Markdown
Member

@bbyalcinkaya bbyalcinkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Thank you! Approving with some change requests. Please apply them before merging.

A few actual Wasm instructions seem to have been moved into HelperInstr. I’ve suggested inline fixes for these.

A practical rule of thumb, if an Instr production has a symbol attribute, it is likely a real Wasm instruction and should remain under Instr. These symbols are used by the binary parser when constructing Wasm ASTs.

Co-authored-by: Burak Bilge Yalçınkaya <bbyalcinkaya@gmail.com>
@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 9a33c05 into master Mar 23, 2026
6 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the anvacaru/helper-sort branch March 23, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants