Race condition check: new volunteers system spec#6745
Open
stefannibrasil wants to merge 6 commits intorubyforgood:mainfrom
Open
Race condition check: new volunteers system spec#6745stefannibrasil wants to merge 6 commits intorubyforgood:mainfrom
stefannibrasil wants to merge 6 commits intorubyforgood:mainfrom
Conversation
It avoids hitting the Database when running system tests
Keep volunteer tests in the same context, and have each test creating its own required setup.
The system test was not checking for anything on the page. This test is better placed at the model level, since it's related to business logic.
Since we're not checking for anything related to an organization, we can speed this test by building factories instead of creating them.
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Related #6698
What changed, and why?
How is this tested? (please write rspec and jest tests!) 💖💪
Everything is a test ⭐