Add shared author_creditable tests for all AuthorCreditable models#1325
Merged
Add shared author_creditable tests for all AuthorCreditable models#1325
Conversation
jmilljr24
approved these changes
Mar 4, 2026
Story and Workshop had partial #author_credit coverage (missing first_name_last_initial and last_name_only). StoryIdea, WorkshopIdea, WorkshopVariation, and WorkshopVariationIdea had none. Extract a shared example that tests all preference values and include it everywhere. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
27a461c to
da07f76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
AuthorCreditableconcern (#author_credit) formats author names based on preference (full name, first name + last initial, first name only, last name only, anonymous)first_name_last_initialandlast_name_onlypreferencesHow did you approach the change?
spec/support/shared_examples/author_creditable.rb) following the existingfeatureableandmentionershared example patternsauthor_credit_preference(StoryIdea, WorkshopVariationIdea)Anything else to add?
🤖 Generated with Claude Code