Fix duplicate .sorted() call causing double joins on bookmarks page

[maebeale]

What is the goal of this PR and why is this important?

• Fixes a production Honeybadger crash: ActiveRecord::StatementInvalid: Trilogy::ProtocolError: 1066: Not unique table/alias: 'community_news' on BookmarksController#personal
• Bookmark.search already calls .sorted() internally, but both controller actions were calling .sorted() again on the result, doubling the SQL joins

How did you approach the change?

• Removed duplicate .sorted() calls from BookmarksController#index and #personal — Bookmark.search already calls .sorted() internally, so calling it again joined the aliased tables a second time
• Fixed existing model specs that replicated the same double-sort bug pattern
• Added model specs covering sort + filter combos (title filter + title/newest/popularity sort, user-scoped + title sort)
• Added request specs for personal and global index with sort=title and title= filter params

UI Testing Checklist

• Verify bookmarks personal page loads without error
• Verify bookmarks personal page with sort=title works
• Verify bookmarks global index (admin) with sort=title works
• Verify bookmarks global index with title search + sort=title works

Anything else to add?

• The aliased table approach (st_ prefix in sort_by_title, wt_ prefix in windows_type) already on main prevents join conflicts between filter and sort scopes — this PR just removes the redundant second .sorted() call that duplicated the aliased joins

🤖 Generated with Claude Code

[jmilljr24]

I'm still getting an error on this when combining a title with windows type.

[jmilljr24]

Sending status to systemd every 1.0 sec
Use Ctrl-C to stop
Started GET "/bookmarks/personal?title=foster&user_id=&bookmarkable_type=&windows_type=Combined&sort=newest" for 127.0.0.1 at 2026-03-03 12:17:19 -0500
  ActiveRecord::SchemaMigration Load (0.6ms)  SELECT `schema_migrations`.`version` FROM `schema_migrations` ORDER BY `schema_migrations`.`version` ASC
Processing by BookmarksController#personal as HTML
  Parameters: {"title" => "foster", "user_id" => "", "bookmarkable_type" => "", "windows_type" => "Combined", "sort" => "newest"}
  User Load (0.7ms)  SELECT `users`.* FROM `users` WHERE `users`.`id` = 9478 ORDER BY `users`.`id` ASC LIMIT 1
  ↳ app/controllers/application_controller.rb:48:in 'ApplicationController#authenticate_user!'
  Bookmark Load (0.8ms)  SELECT `bookmarks`.* FROM `bookmarks` WHERE `bookmarks`.`user_id` = 9478
  ↳ app/controllers/application_controller.rb:72:in 'ApplicationController#preload_current_user_associations'
  Person Load (0.8ms)  SELECT `people`.* FROM `people` WHERE `people`.`id` = 1 LIMIT 1
  ↳ app/controllers/application_controller.rb:74:in 'ApplicationController#preload_current_user_associations'
  Affiliation Load (0.7ms)  SELECT `affiliations`.* FROM `affiliations` WHERE `affiliations`.`person_id` = 1 AND `affiliations`.`inactive` = FALSE AND (end_date IS NULL OR end_date >= '2026-03-03')
  ↳ app/controllers/application_controller.rb:79:in 'ApplicationController#preload_current_user_associations'
  Bookmark Load (1.3ms)  SELECT `bookmarks`.* FROM `bookmarks` LEFT JOIN community_news      ON community_news.id      = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'CommunityNews'
LEFT JOIN events              ON events.id              = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Event'
LEFT JOIN organizations       ON organizations.id       = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Organization'
LEFT JOIN people              ON people.id              = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Person'
LEFT JOIN resources           ON resources.id           = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Resource'
LEFT JOIN stories             ON stories.id             = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Story'
LEFT JOIN story_ideas         ON story_ideas.id         = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'StoryIdea'
LEFT JOIN workshops           ON workshops.id           = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Workshop'
LEFT JOIN workshop_ideas      ON workshop_ideas.id      = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'WorkshopIdea'
LEFT JOIN workshop_logs       ON workshop_logs.id       = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'WorkshopLog'
LEFT JOIN workshop_variations ON workshop_variations.id = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'WorkshopVariation' WHERE `bookmarks`.`user_id` = 9478 AND (community_news.title
       people.last_name LIKE '%foster%' OR organizations.name LIKE '%foster%' OR resources.title LIKE '%foster%' OR
       stories.title LIKE '%foster%' OR workshops.title LIKE '%foster%' OR workshop_ideas.title LIKE '%foster%' OR
       story_ideas.body LIKE '%foster%' OR
       DATE_FORMAT(workshop_logs.date, '%Y-%m-%d') LIKE '%foster%' OR
       workshop_variations.name LIKE '%foster%') AND (`bookmarks`.`id` IN (SELECT `bookmarks`.`id` FROM `bookmarks` LEFT JOIN community_news      ON community_news.id      = bookmarks.bookmarkable_i
LEFT JOIN events              ON events.id              = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Event'
LEFT JOIN organizations       ON organizations.id       = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Organization'
LEFT JOIN people              ON people.id              = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Person'
LEFT JOIN resources           ON resources.id           = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Resource'
LEFT JOIN stories             ON stories.id             = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Story'
LEFT JOIN story_ideas         ON story_ideas.id         = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'StoryIdea'
LEFT JOIN workshops           ON workshops.id           = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Workshop'
LEFT JOIN workshop_ideas      ON workshop_ideas.id      = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'WorkshopIdea'
LEFT JOIN workshop_logs       ON workshop_logs.id       = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'WorkshopLog'
LEFT JOIN workshop_variations ON workshop_variations.id = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'WorkshopVariation' INNER JOIN resources
  ON resources.id = bookmarks.bookmarkable_id
 AND bookmarks.bookmarkable_type = 'Resource'
INNER JOIN windows_types
  ON windows_types.id = resources.windows_type_id
  AND resources.windows_type_id IS NOT NULL WHERE `bookmarks`.`user_id` = 9478 AND (community_news.title LIKE '%foster%' OR events.title LIKE '%foster%' OR people.first_name LIKE '%foster%' OR
       people.last_name LIKE '%foster%' OR organizations.name LIKE '%foster%' OR resources.title LIKE '%foster%' OR
       stories.title LIKE '%foster%' OR workshops.title LIKE '%foster%' OR workshop_ideas.title LIKE '%foster%' OR
       story_ideas.body LIKE '%foster%' OR
       DATE_FORMAT(workshop_logs.date, '%Y-%m-%d') LIKE '%foster%' OR
       workshop_variations.name LIKE '%foster%') AND (windows_types.name LIKE '%COMBINED%')) OR `bookmarks`.`id` IN (SELECT `bookmarks`.`id` FROM `bookmarks` LEFT JOIN community_news      ON community_news.id      = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'CommunityNews'
LEFT JOIN events              ON events.id              = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Event'
LEFT JOIN organizations       ON organizations.id       = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Organization'
LEFT JOIN people              ON people.id              = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Person'
LEFT JOIN resources           ON resources.id           = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Resource'
LEFT JOIN stories             ON stories.id             = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Story'
LEFT JOIN story_ideas         ON story_ideas.id         = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'StoryIdea'
LEFT JOIN workshops           ON workshops.id           = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'Workshop'
LEFT JOIN workshop_ideas      ON workshop_ideas.id      = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'WorkshopIdea'
LEFT JOIN workshop_logs       ON workshop_logs.id       = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'WorkshopLog'
LEFT JOIN workshop_variations ON workshop_variations.id = bookmarks.bookmarkable_id AND bookmarks.bookmarkable_type = 'WorkshopVariation' LEFT JOIN workshops
  ON workshops.id = bookmarks.bookmarkable_id
 AND bookmarks.bookmarkable_type = 'Workshop'
LEFT JOIN windows_types
  ON windows_types.id = workshops.windows_type_id
  AND workshops.windows_type_id IS NOT NULL WHERE `bookmarks`.`user_id` = 9478 AND (community_news.title LIKE '%foster%' OR events.title LIKE '%foster%' OR people.first_name LIKE '%foster%' OR
       people.last_name LIKE '%foster%' OR organizations.name LIKE '%foster%' OR resources.title LIKE '%foster%' OR
       stories.title LIKE '%foster%' OR workshops.title LIKE '%foster%' OR workshop_ideas.title LIKE '%foster%' OR
       story_ideas.body LIKE '%foster%' OR
       DATE_FORMAT(workshop_logs.date, '%Y-%m-%d') LIKE '%foster%' OR
       workshop_variations.name LIKE '%foster%') AND (windows_types.name LIKE '%COMBINED%'))) ORDER BY `bookmarks`.`created_at` DESC
  ↳ app/controllers/bookmarks_controller.rb:31:in 'BookmarksController#personal'
Completed 500 Internal Server Error in 61ms (ActiveRecord: 10.7ms (5 queries, 0 cached) | GC: 0.8ms)



ActiveRecord::StatementInvalid - Trilogy::ProtocolError: 1066: Not unique table/alias: 'resources' (trilogy_query_recv):
  app/controllers/bookmarks_controller.rb:31:in `personal'

[maebeale]

@jmilljr24 would you try again?