Fix link stories View button to external URL#1320
Merged
Conversation
- View button now links directly to the external URL (opening in a new tab) for stories with a website_url, matching card behavior - Added admin-only "Details" button so admins can still access the internal show page when an external URL is present - Added request specs covering external link handling for both admin and regular user roles Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
show? allows regular users to see published stories, so the Details button was appearing for non-admins. Switch to edit? which requires admin, consistent with the Edit button. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maebeale
changed the title
jmilljr24
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
no_redirect), even for stories with an external URLHow did you approach the change?
admin-only bg-blue-100) that links to the internal show page withno_redirect: true, so admins can still access the show pageUI Testing Checklist
Anything else to add?
🤖 Generated with Claude Code