Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["github>rstackjs/renovate"]
$schema: 'https://docs.renovatebot.com/renovate-schema.json',
extends: ['github>rstackjs/renovate'],
}
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
# Run `npm run bump` to bump the version and create a git tag.
push:
tags:
- "v*"
- 'v*'

workflow_dispatch:

Expand Down Expand Up @@ -46,4 +46,4 @@ jobs:
- name: Create GitHub Release
uses: ncipollo/release-action@339a81892b84b4eeb0f6e744e4574d79d0d9b8dd # v1
with:
generateReleaseNotes: "true"
generateReleaseNotes: 'true'
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 24.15.0
cache: "pnpm"
cache: 'pnpm'

- name: Install Dependencies
run: pnpm install && npx playwright install
Expand Down
3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Ignore artifacts:
dist
pnpm-lock.yaml
3 changes: 3 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"singleQuote": true
}
2 changes: 1 addition & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"recommendations": ["biomejs.biome"]
"recommendations": ["rstack.rslint", "esbenp.prettier-vscode"]
}
13 changes: 1 addition & 12 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,4 @@
{
"search.useIgnoreFiles": true,
"[json]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[typescript]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[javascript]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[javascriptreact]": {
"editor.defaultFormatter": "biomejs.biome"
}
"cSpell.words": ["rslint"]
}
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Add plugin to your `rsbuild.config.ts`:

```ts
// rsbuild.config.ts
import { pluginBasicSsl } from "@rsbuild/plugin-basic-ssl";
import { pluginBasicSsl } from '@rsbuild/plugin-basic-ssl';

export default {
plugins: [pluginBasicSsl()],
Expand All @@ -44,7 +44,7 @@ Filename of the generated certificate.

```ts
pluginBasicSsl({
filename: "foo.pem",
filename: 'foo.pem',
});
```

Expand All @@ -57,10 +57,10 @@ Output path of the generated certificate.
- **Example:**

```ts
import path from "node:path";
import path from 'node:path';

pluginBasicSsl({
outputPath: path.join(__dirname, "node_modules/.cache/cert"),
outputPath: path.join(__dirname, 'node_modules/.cache/cert'),
});
```

Expand All @@ -72,14 +72,14 @@ Attributes passing to `selfsigned`, see [selfsigned](https://github.com/jfromani
- **Default:**

```ts
const defaultAttrs = [{ name: "commonName", value: "localhost" }];
const defaultAttrs = [{ name: 'commonName', value: 'localhost' }];
```

- **Example:**

```ts
pluginBasicSsl({
selfsignedAttrs: [{ name: "commonName", value: "example.com" }],
selfsignedAttrs: [{ name: 'commonName', value: 'example.com' }],
});
```

Expand Down
23 changes: 0 additions & 23 deletions biome.json

This file was deleted.

19 changes: 7 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,31 +20,26 @@
"scripts": {
"build": "rslib",
"dev": "rslib -w",
"lint": "biome check .",
"lint:write": "biome check . --write",
"prepare": "simple-git-hooks && npm run build",
"lint": "rslint && prettier -c .",
"lint:write": "rslint --fix && prettier -w .",
"prepare": "simple-git-hooks && pnpm run build",
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"prepare"is executed by npm during installs from git (and in some publish flows). Hard-codingpnpmhere can break consumers/environments that runnpm installbut don’t havepnpmavailable on PATH. Prefer usingnpm run build` (npm is guaranteed in that context), or otherwise ensure the script is package-manager-agnostic (e.g., via a node script) if you want to keep pnpm as the primary dev tool.

Suggested change
"prepare": "simple-git-hooks && pnpm run build",
"prepare": "simple-git-hooks && npm run build",

Copilot uses AI. Check for mistakes.
"test": "playwright test",
"bump": "npx bumpp"
"bump": "pnpx bumpp"
},
"simple-git-hooks": {
"pre-commit": "npx nano-staged"
},
"nano-staged": {
"*.{js,jsx,ts,tsx,mjs,cjs}": [
"biome check --write --no-errors-on-unmatched"
]
"pre-commit": "pnpm run lint:write"
},
Comment on lines 29 to 31
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running lint:write on pre-commit will format/lint the entire repository, which can (1) significantly slow down commits and (2) modify files that aren’t staged, leaving the working tree dirty and potentially surprising the committer. Consider switching the hook back to a staged-files-only workflow (e.g., lint-staged/nano-staged) or wiring the hook to only pass staged file paths to Prettier/Rslint.

Copilot uses AI. Check for mistakes.
"dependencies": {
"selfsigned": "^3.0.1"
},
"devDependencies": {
"@biomejs/biome": "^1.9.4",
"@playwright/test": "^1.59.1",
"@rsbuild/core": "1.7.5",
"@rslib/core": "^0.21.3",
"@rslint/core": "^0.5.0",
"@types/node": "^24.12.2",
"nano-staged": "^1.0.2",
"playwright": "^1.59.1",
"prettier": "^3.8.3",
"simple-git-hooks": "^2.13.1",
"typescript": "6.0.3"
},
Expand Down
14 changes: 7 additions & 7 deletions playground/package.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "playground",
"private": true,
"version": "0.0.0",
"scripts": {
"dev": "npx rsbuild",
"build": "npx rsbuild build"
}
"name": "playground",
"private": true,
"version": "0.0.0",
"scripts": {
"dev": "npx rsbuild",
"build": "npx rsbuild build"
}
}
2 changes: 1 addition & 1 deletion playground/rsbuild.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ import { defineConfig } from '@rsbuild/core';
import { pluginBasicSsl } from '../src';

export default defineConfig({
plugins: [pluginBasicSsl()],
plugins: [pluginBasicSsl()],
});
Loading
Loading