-
Notifications
You must be signed in to change notification settings - Fork 1
chore: migrate to Rslint and Prettier #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "extends": ["github>rstackjs/renovate"] | ||
| $schema: 'https://docs.renovatebot.com/renovate-schema.json', | ||
| extends: ['github>rstackjs/renovate'], | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Ignore artifacts: | ||
| dist | ||
| pnpm-lock.yaml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "singleQuote": true | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "recommendations": ["biomejs.biome"] | ||
| "recommendations": ["rstack.rslint", "esbenp.prettier-vscode"] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,4 @@ | ||
| { | ||
| "search.useIgnoreFiles": true, | ||
| "[json]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[typescript]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[javascript]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| }, | ||
| "[javascriptreact]": { | ||
| "editor.defaultFormatter": "biomejs.biome" | ||
| } | ||
| "cSpell.words": ["rslint"] | ||
| } |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,31 +20,26 @@ | |
| "scripts": { | ||
| "build": "rslib", | ||
| "dev": "rslib -w", | ||
| "lint": "biome check .", | ||
| "lint:write": "biome check . --write", | ||
| "prepare": "simple-git-hooks && npm run build", | ||
| "lint": "rslint && prettier -c .", | ||
| "lint:write": "rslint --fix && prettier -w .", | ||
| "prepare": "simple-git-hooks && pnpm run build", | ||
| "test": "playwright test", | ||
| "bump": "npx bumpp" | ||
| "bump": "pnpx bumpp" | ||
| }, | ||
| "simple-git-hooks": { | ||
| "pre-commit": "npx nano-staged" | ||
| }, | ||
| "nano-staged": { | ||
| "*.{js,jsx,ts,tsx,mjs,cjs}": [ | ||
| "biome check --write --no-errors-on-unmatched" | ||
| ] | ||
| "pre-commit": "pnpm run lint:write" | ||
| }, | ||
|
Comment on lines
29
to
31
|
||
| "dependencies": { | ||
| "selfsigned": "^3.0.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@biomejs/biome": "^1.9.4", | ||
| "@playwright/test": "^1.59.1", | ||
| "@rsbuild/core": "1.7.5", | ||
| "@rslib/core": "^0.21.3", | ||
| "@rslint/core": "^0.5.0", | ||
| "@types/node": "^24.12.2", | ||
| "nano-staged": "^1.0.2", | ||
| "playwright": "^1.59.1", | ||
| "prettier": "^3.8.3", | ||
| "simple-git-hooks": "^2.13.1", | ||
| "typescript": "6.0.3" | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| { | ||
| "name": "playground", | ||
| "private": true, | ||
| "version": "0.0.0", | ||
| "scripts": { | ||
| "dev": "npx rsbuild", | ||
| "build": "npx rsbuild build" | ||
| } | ||
| "name": "playground", | ||
| "private": true, | ||
| "version": "0.0.0", | ||
| "scripts": { | ||
| "dev": "npx rsbuild", | ||
| "build": "npx rsbuild build" | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"prepare"
is executed by npm during installs from git (and in some publish flows). Hard-codingpnpmhere can break consumers/environments that runnpm installbut don’t havepnpmavailable on PATH. Prefer usingnpm run build` (npm is guaranteed in that context), or otherwise ensure the script is package-manager-agnostic (e.g., via a node script) if you want to keep pnpm as the primary dev tool.