Remove unused juwelier development dependency#286
Merged
yahonda merged 1 commit intorsim:masterfrom May 7, 2026
Merged
Conversation
The gemspec is now hand-maintained as ruby-plsql.gemspec, so the Juwelier::Tasks block in the Rakefile (guarded by rescue LoadError) and the gem 'juwelier', '~> 2.0' line in every gemfiles/Gemfile.activerecord-* variant are dead weight. Drop them so contributors are not misled into thinking juwelier is still part of the build or release flow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruby-plsql.gemspec, so theJuwelier::Tasksblock in theRakefile(already guarded byrescue LoadErrorbecause the top-levelGemfilelong ago dropped juwelier) is dead code.gemfiles/Gemfile.activerecord-*variant still listedgem 'juwelier', '~> 2.0'in:development— pointless for CI and misleading to contributors.History.txt's "Migrate from jeweler to juwelier" line is intentionally kept as a historical changelog entry.Test plan
bundle installat the repo root resolves cleanly.BUNDLE_GEMFILE=gemfiles/Gemfile.activerecord-8.1 bundle install(and a spot-check of one or two other variants) resolves cleanly.bundle exec rake -Tlists the rspec/rdoc tasks without error (no juwelier-only tasks were relied on)..github/workflows/test_gemfiles.ymlis green across every gemfile variant.🤖 Generated with Claude Code