Move activerecord-main Gemfile to top level and add gemfiles/Gemfile.activerecord-8.1#281
Merged
yahonda merged 1 commit intorsim:masterfrom May 5, 2026
Merged
Conversation
yahonda
changed the title
yahonda
force-pushed
the
bump-rails-8-1
branch
2 times, most recently
from
a33e95c to
ae37d45
Compare
…ecord-8.1 Top-level Gemfile now tracks Rails main (rails/rails:main) and the oracle-enhanced adapter master (rsim/oracle-enhanced:master), mirroring how the previous gemfiles/Gemfile.activerecord-main pulled in bleeding-edge dependencies. Picking up rails/rails main as the default development target surfaces upstream regressions earlier than waiting for a released Rails line. Add gemfiles/Gemfile.activerecord-8.1 pinned to ~> 8.1.0 (matching the style of Gemfile.activerecord-8.0) and wire it into .github/workflows/test_gemfiles.yml so 8.1 gets the same matrix coverage the other released Rails lines have. The 8.1 row uses Ruby 3.3 because activerecord-oracle_enhanced-adapter 8.1.x requires Ruby >= 3.3.1. Drop Ruby 3.2 from .github/workflows/test.yml and test_11g.yml matrices for the same reason: those workflows resolve against the top-level Gemfile, which now pulls oracle-enhanced master and inherits its Ruby >= 3.3.1 requirement. Ruby 3.2 coverage continues through gemfiles/Gemfile.activerecord-8.0 (and earlier rows) in test_gemfiles.yml. Remove the redundant gemfiles/Gemfile.activerecord-main; tracking Rails main now happens in the top-level Gemfile. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gemfilenow tracks Rails main (rails/rails:main) and the oracle-enhanced adapter master (rsim/oracle-enhanced:master) — the bleeding-edge dependency strategy that previously lived ingemfiles/Gemfile.activerecord-main. Picking up Rails main as the default development target surfaces upstream regressions earlier than waiting for a released Rails line.gemfiles/Gemfile.activerecord-8.1pinned to~> 8.1.0(matching the style ofGemfile.activerecord-8.0) and wire it into.github/workflows/test_gemfiles.ymlso 8.1 gets the same matrix coverage as the other released Rails lines.gemfiles/Gemfile.activerecord-main; tracking Rails main now happens in the top-levelGemfile.Test plan
.github/workflows/test.yml,test_11g.yml,devcontainer.yml— green against Rails main + oracle_enhanced master via the new top-levelGemfile..github/workflows/test_gemfiles.yml— the newGemfile.activerecord-8.1row resolves toactiverecord 8.1.xand the suite passes.bundle installagainst the new top-levelGemfileresolves cleanly (locally fetchedactiverecord 8.2.0.alphafromrails/rails:main).🤖 Generated with Claude Code