Skip to content

Fix fromDataView: enumerable, complete comment, optional setter, readonly inference#5

Merged
rotu merged 2 commits intomainfrom
copilot/fix-fromdataview-field-issues
Mar 27, 2026
Merged

Fix fromDataView: enumerable, complete comment, optional setter, readonly inference#5
rotu merged 2 commits intomainfrom
copilot/fix-fromdataview-field-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

  • Fix fromDataView in fields.ts:
    • Complete the incomplete JSDoc comment
    • Add enumerable: true to the returned descriptor
    • Add overloads to accept an optional setter (dv: DataView, value: T) => void
    • Return StructPropertyDescriptor<T> & ReadOnlyAccessorDescriptor<T> when no setter (readonly), StructPropertyDescriptor<T> when setter provided (writable)
  • Add tests in mod_test.ts:
    • Import fromDataView
    • Test getter-only (readonly) behavior, type inference, and enumerability
    • Test getter+setter (writable) behavior, type inference, and enumerability
  • Bump package minor version to 0.15.0

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copy link
Copy Markdown
Owner

@rotu rotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump package minor version

Agent-Logs-Url: https://github.com/rotu/structview/sessions/efb92433-db0a-46bd-9a9d-ad2cbf60cf75

Co-authored-by: rotu <119948+rotu@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 27, 2026

please bump package minor version

Done — bumped to 0.15.0 in commit 653534e.

Copilot AI requested a review from rotu March 27, 2026 07:42
Copilot finished work on behalf of rotu March 27, 2026 07:42
@rotu rotu marked this pull request as ready for review March 27, 2026 15:30
@rotu rotu merged commit cc3b63a into main Mar 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants