Skip to content

remove ament_export_link_flags() for atomic operations.#528

Open
fujitatomoya wants to merge 2 commits intorollingfrom
fujitatomoya/issues/525
Open

remove ament_export_link_flags() for atomic operations.#528
fujitatomoya wants to merge 2 commits intorollingfrom
fujitatomoya/issues/525

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Dec 13, 2025

Description

Fixes #525

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

@fujitatomoya fujitatomoya mentioned this pull request Dec 13, 2025
Open
fujitatomoya
fujitatomoya commented Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this approach (linking atomic directly into librcutils.so instead of exporting the flag) solves #525 without regressing #516, because the atomic symbols get baked into the rcutils shared library itself. downstream packages never need to find libatomic on their own, regardless of whether BUILD_TESTING is on or off.

@fujitatomoya fujitatomoya marked this pull request as ready for review March 13, 2026 02:35
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Mar 13, 2026

@Mergifyio rebase

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 13, 2026

rebase

✅ Branch has been successfully rebased

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/issues/525 branch from 6669cba to 4bb0010 Compare March 13, 2026 02:35
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Mar 13, 2026 •
edited
Loading

Pulls: #528
Gist: https://gist.githubusercontent.com/fujitatomoya/8f6118d27145c753c7c7e8c4bdb9125b/raw/e01ee9af10bd9fce804700d1676ebbcd92dda868/ros2.repos
BUILD args: --packages-above-and-dependencies rcutils
TEST args: --packages-above rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18457

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya requested a review from ahcorde March 16, 2026 23:17
@fujitatomoya fujitatomoya self-assigned this Mar 16, 2026
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Mar 23, 2026

@Mergifyio rebase

fujitatomoya and others added 2 commits March 23, 2026 17:40
@fujitatomoya
remove ament_export_link_flags() for atomic operations.
6390895 
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
@fujitatomoya
adjust the comment.
4c4674e 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/issues/525 branch from 4deae0f to 4c4674e Compare March 23, 2026 08:40
@mergify
Copy link
Copy Markdown

mergify bot commented Mar 23, 2026

rebase

✅ Branch has been successfully rebased

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Mar 23, 2026

Pulls: #528
Gist: https://gist.githubusercontent.com/fujitatomoya/7674a8419b19d96d2aecb242074335ac/raw/e01ee9af10bd9fce804700d1676ebbcd92dda868/ros2.repos
BUILD args: --packages-above-and-dependencies rcutils
TEST args: --packages-above rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18603

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Mar 23, 2026

@ahcorde friendly ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package 'rcutils' exports the library 'rcutils' which couldn't be found

1 participant

@fujitatomoya