Skip to content

fix: warning about orogen model being modified in logging configuration #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doudou wants to merge 2 commits into
base: transition-to-runkit
Choose a base branch
from
+10 −2
Open

fix: warning about orogen model being modified in logging configuration #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d58e46
fix: warning about orogen model being modified in logging configuration
doudou May 9, 2026
81f10eb
fix: do set use_rock_time_field_for_logging in its testcase
doudou May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/syskit/deployment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,11 @@ def instanciate_default_logger_task(logger_name)
return
end

syskit_model = model.resolve_syskit_model_for_deployed_task(orogen_model)
_, syskit_model =
instanciate_deployed_task_resolve_task_model(
logger_name, orogen_model, nil
)

return unless syskit_model.fullfills?(LoggerService)

# Automatic setup by
Expand Down
6 changes: 5 additions & 1 deletion test/live/test_logger_logical_time.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ class LogicalTimeLoggingTest < Syskit::Test::ComponentTest
attr_reader :task

before do
skip unless Syskit.conf.use_rock_time_field_for_logging?
@__use_rock_time_field_for_logging =
Syskit.conf.use_rock_time_field_for_logging?
Syskit.conf.use_rock_time_field_for_logging = true

Syskit.conf.logs.enable_port_logging
@task = syskit_deploy(
Expand All @@ -40,6 +42,8 @@ class LogicalTimeLoggingTest < Syskit::Test::ComponentTest
end

after do
Syskit.conf.use_rock_time_field_for_logging =
@__use_rock_time_field_for_logging
Syskit.conf.logs.disable_port_logging
end

Expand Down