Fix configuration precedence on replacement#559
Open
doudou wants to merge 3 commits intotransition-to-runkitfrom
Open
Fix configuration precedence on replacement#559doudou wants to merge 3 commits intotransition-to-runkitfrom
doudou wants to merge 3 commits intotransition-to-runkitfrom
Conversation
doudou
force-pushed
the
fix_configuration_precedence_on_replacement
branch
from
7d8f831 to
df362a4
Compare
…copy_on_replace: true A few months back I noticed that uring repeated deployments and reconfigurations, some configuration precedence edges would be lost. I tracked it to the behaviour of replacements to move relations. At the time, I added strong: true to the syskit configuration precedence graph. But this, actually as documented in Roby::Relations::Graph, causes the edges to be completely ignored during replacements. Definitely not what we want in Syskit, where replacement is heavily used as a plan transformation tool during network generation, deployment and adaptation. In practice, this caused the precedence constraints to be *completely* lost (and a heisenbug that we studiously ignored). This commit depends on a change in Roby which allows to copy strong relations (while keeping the do-not-remove-automatically behaviour of strong relations). Set the flag and add the relevant regression test
doudou
force-pushed
the
fix_configuration_precedence_on_replacement
branch
from
df362a4 to
22c8365
Compare
wvmcastro
reviewed
May 8, 2026
| syskit_stub_configured_deployment(combus_driver_m) | ||
| dev_driver = syskit_deploy(dev) | ||
| bus_driver = plan.find_tasks(combus_driver_m).with_parent(dev_driver).first | ||
| refute dev_driver.meets_configurationg_precedence_constraints? |
There was a problem hiding this comment.
Out of curiosity, what happens if syskit_configure(dev_driver) is called? It will be a no-op or some kind of exception will be thrown?
wvmcastro
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: