Fix for positional argument not being case sensitive.#306
Open
alexswan10k wants to merge 1 commit intorlidwka:masterfrom
Open
Fix for positional argument not being case sensitive.#306alexswan10k wants to merge 1 commit intorlidwka:masterfrom
alexswan10k wants to merge 1 commit intorlidwka:masterfrom
Conversation
Owner
|
Route parameter name is case-sensitive. Is there a way to reproduce this issue you encountered? How do you upload these packages? |
Author
|
This is simply done by cloning any repository with upper case characters, and then using npm publish: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst uploading some mirrored packages, we came across some problems due to capitalization. It appears that the app does a compare of the object name (case sensitive) with the route parameter name (case insensitive), and thus will fail if packages have capital letters in their name.
The offending packages that raised the problem:
JSONStream
Base64
I have relaxed the check to be case insensitive, which seems to have fixed the problem.