Merged
Conversation
JSON viewer output could vary based on object key order from incoming payloads, which made payloads harder to scan and compare across views and copy/paste workflows. This change makes rendered and copied JSON output deterministic by sorting object keys consistently.
bgentry
force-pushed
the
bg/fix-json-viewer-key-ordering
branch
from
9896b97 to
6419df9
Compare
Contributor
Author
|
I'm not 100% sure this is the "correct" thing to do, like you could definitely argue for sorting at an earlier point and/or preserving the order of the actual JSON. At least with metadata though I've been getting some pretty weird displays without this so it seems best to just sort client side. I feel less strongly about args. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON viewer output could vary based on object key order from incoming payloads, which made payloads harder to scan and compare across views and copy/paste workflows. This change makes rendered and copied JSON output deterministic by sorting object keys consistently.