Add Schema parameter to API endpoint requests#517
Open
tp wants to merge 1 commit intoriverqueue:masterfrom
Open
Add Schema parameter to API endpoint requests#517tp wants to merge 1 commit intoriverqueue:masterfrom
tp wants to merge 1 commit intoriverqueue:masterfrom
Conversation
Contributor
|
Hi @tp! Thanks for reporting this and attempting a fix. Two requests for you before we proceed further:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed errors like
when using the autocomplete in the job list.
As this was my first hour using River, I just gave the error to Claude who immediately pointed out the inconsistencies between the 2 fixed methods (which did not pass the schema) and the others which do.
Depending on if you're fine with this, I could take more time later on to align this more with the repo style or add tests. Whatever is desired :)