Adds YAML to Zod Schema, YAML category#376
Open
thatrobotdev wants to merge 3 commits intoritz078:masterfrom
Open
Adds YAML to Zod Schema, YAML category#376thatrobotdev wants to merge 3 commits intoritz078:masterfrom
thatrobotdev wants to merge 3 commits intoritz078:masterfrom
Conversation
- Adds a YAML to Zod Schema transformer by first converting the YAML to JSON using the same method as the YAML to JSON transformer, then converting the JSON to Zod Schema using the same method as the JSON to Zod Schema transformer. - Creates a new YAML category in the sidebar
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ritz078
reviewed
Feb 17, 2024
Comment on lines
-390
to
-391
| label: "TOML to YAML", | ||
| path: "/toml-to-yaml" |
Collaborator
|
Hey! Thanks for the pull request! I will message again when that time has come 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems with this PR ;)
The implementation in this PR works, but has some minor flaws that I need help fixing! It could be merged as is with these caveats:
packageNameorpackageUrlinroutes.tsxbecause it uses both the packages json-to-zod and yaml.YamlToJson()andJsonToZod()without importing them.YamlToJson()andJsonToZod()directly instead of being made up of their code.