Skip to content

fix clickhouse test#8988

Merged
NamanMahor merged 2 commits intomainfrom
fixing_clickhouse_test
Mar 10, 2026
Merged

fix clickhouse test#8988
NamanMahor merged 2 commits intomainfrom
fixing_clickhouse_test

Conversation

@NamanMahor
Copy link
Copy Markdown
Contributor

@NamanMahor NamanMahor commented Mar 6, 2026

fix clickhouse test

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Comment thread runtime/queries/metricsview_timeseries_test.go Outdated
@NamanMahor NamanMahor self-assigned this Mar 9, 2026
@NamanMahor NamanMahor requested review from k-anshul March 9, 2026 06:20
Copy link
Copy Markdown
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR looks good to me. I see Anshul has a concern, so will defer to @k-anshul for the final approval.

@NamanMahor NamanMahor merged commit d091868 into main Mar 10, 2026
12 checks passed
@NamanMahor NamanMahor deleted the fixing_clickhouse_test branch March 10, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants