Open
Conversation
|
A preview of 350b179 is uploaded and can be seen here: ✨ https://revisit.dev/study/PR1167 ✨ Changes may take a few minutes to propagate. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an “unanswered required questions” UX to response forms so participants can quickly see what still needs attention before proceeding.
Changes:
- Introduces
showUnansweredflow to display per-question prompts for required-but-empty responses and a total unanswered count message. - Adds visual highlighting for required unanswered responses in
ResponseSwitcher. - Extends
NextButtonto notify the parent when Next is attempted while disabled (to trigger highlighting).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/response/utils.ts | Adds requiredAnswerIsEmpty and extends generateErrorMessage with showUnanswered support. |
| src/components/response/ResponseBlock.tsx | Tracks showUnanswered, computes unanswered count, and shows a summary alert; wires onNextAttempted. |
| src/components/response/ResponseSwitcher.tsx | Computes unanswered-required state and applies highlight styling; threads showUnanswered to inputs. |
| src/components/NextButton.tsx | Adds onNextAttempted and changes click handling to allow “attempt” behavior when disabled. |
| src/components/response/*Input.tsx | Passes showUnanswered through to generateErrorMessage / local required messaging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #937
Give a longer description of what this PR addresses and why it's needed
Add highlighting for unanswered items in a form
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
TODOs: