Replace the deprecated /cluster-health endpoint with gRPC call#420
Draft
muhamadazmy wants to merge 1 commit into
Draft
Replace the deprecated /cluster-health endpoint with gRPC call#420muhamadazmy wants to merge 1 commit into
muhamadazmy wants to merge 1 commit into
Conversation
Summary: This drops the use of the deprecated /cluster-health endpoint and use the Restate metadata server gRPC service instead
Test Results 5 files ±0 5 suites ±0 2m 26s ⏱️ - 2m 19s For more details on these failures, see this check. Results for commit 1b6348d. ± Comparison against base commit b8c685b. |
Comment on lines
+27
to
+28
| layout.buildDirectory.dir("generated/source/proto/main/java"), | ||
| layout.buildDirectory.dir("generated/source/proto/main/grpc")) |
Collaborator
There was a problem hiding this comment.
i dont think you need this, protobuf gradle plugin should do this ootb
| dependsOn(openApiGenerate) | ||
| dependsOn(generateJsonSchema2Pojo) | ||
| dependsOn(withType<GenerateTask>()) | ||
| dependsOn(withType<com.google.protobuf.gradle.GenerateProtoTask>()) |
Collaborator
There was a problem hiding this comment.
i also dont thiink you need this
| client.clusterHealth().metadataClusterHealth?.members?.size == numberRestateNodes | ||
| } catch (e: ApiException) { | ||
| val response = | ||
| MetadataServerSvcGrpc.newBlockingStub(channel).status(Empty.getDefaultInstance()) |
| e) | ||
| throw IllegalStateException("Error when checking metadata server status: ${e.status}", e) | ||
| } finally { | ||
| channel.shutdownNow() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated /cluster-health endpoint with gRPC call
Summary:
This drops the use of the deprecated /cluster-health endpoint
and use the Restate metadata server gRPC service instead