Skip to content

Tests for scope and concurrency limit#418

Open
slinkydeveloper wants to merge 4 commits into
mainfrom
scope-tests
Open

Tests for scope and concurrency limit#418
slinkydeveloper wants to merge 4 commits into
mainfrom
scope-tests

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Collaborator

No description provided.

@slinkydeveloper
Copy link
Copy Markdown
Collaborator Author

Part of restatedev/restate#4659

}
// Briefly confirm the count stays at `limit`, defending against a slow rule activation
// where all 4 would have started before our first check.
delay(1.seconds)
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO This is 100% not right.

@tillrohrmann how can i reliably assert all nodes have the same rule book propagated?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something we need to expose in the PartitionProcessorStatus and then you can query it via the partition_state table.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into it.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is soimething we can have for the schema registry in general, would be awesome btw, because i have some other tests that has the same issue: depending on the metadata propagation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this restatedev/restate#4783 helps.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

Test Results

 5 files  ±0   5 suites  ±0   2m 17s ⏱️ - 2m 28s
45 tests +2  37 ✅  - 2  0 💤 ±0  0 ❌  - 3  8 🔥 +7 
68 runs  +4  60 ✅ ±0  0 💤 ±0  0 ❌  - 3  8 🔥 +7 

For more details on these errors, see this check.

Results for commit 73410f5. ± Comparison against base commit b8c685b.

♻️ This comment has been updated with latest results.

@tillrohrmann
Copy link
Copy Markdown
Contributor

Thanks a lot for adding these tests @slinkydeveloper 🦸. I am going to look into expose the current rule book version as part of the partition state. Then we can use this to wait until all partitions are using the latest rule book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants