Skip to content

require the GITHUB_TOKEN and OP_SERVICE_ACCOUNT_PRODUCTION env vars #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laverya merged 1 commit into from
Mar 26, 2026
Merged

require the GITHUB_TOKEN and OP_SERVICE_ACCOUNT_PRODUCTION env vars #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions dagger/release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ func (r *Replicated) Release(

githubToken *dagger.Secret,
) error {
// Check all required environment variables / secrets before starting work
if err := validateReleaseSecrets(ctx, githubToken, onePasswordServiceAccountProduction); err != nil {
return err
}

err := checkGitTree(ctx, source, githubToken)
if err != nil {
return errors.Wrap(err, "failed to check git tree")
Expand Down Expand Up @@ -213,6 +218,40 @@ func (r *Replicated) Release(
return nil
}

func validateReleaseSecrets(ctx context.Context, githubToken, onePasswordServiceAccountProduction *dagger.Secret) error {
var missing []string

if githubToken == nil {
missing = append(missing, "GITHUB_TOKEN")
} else {
gt, err := githubToken.Plaintext(ctx)
if err != nil {
return errors.Wrap(err, "failed to read GITHUB_TOKEN secret")
}
if strings.TrimSpace(gt) == "" {
missing = append(missing, "GITHUB_TOKEN")
}
}

if onePasswordServiceAccountProduction == nil {
missing = append(missing, "OP_SERVICE_ACCOUNT_PRODUCTION")
} else {
op, err := onePasswordServiceAccountProduction.Plaintext(ctx)
if err != nil {
return errors.Wrap(err, "failed to read OP_SERVICE_ACCOUNT_PRODUCTION secret")
}
if strings.TrimSpace(op) == "" {
missing = append(missing, "OP_SERVICE_ACCOUNT_PRODUCTION")
}
}

if len(missing) > 0 {
return fmt.Errorf("required environment variables are not set: %s", strings.Join(missing, ", "))
}

return nil
}

func getNextVersion(ctx context.Context, latestVersion string, version string) (int64, int64, int64, error) {
parsedLatestVersion, err := semver.NewVersion(latestVersion)
if err != nil {
Expand Down
Loading