fix(azure): custom image for Azure RHEL AI#748
fix(azure): custom image for Azure RHEL AI#748adrianriobo merged 1 commit intoredhat-developer:mainfrom
Conversation
ppitonak
force-pushed
the
azure_custom_image
branch
from
059b1ba to
8dc9f14
Compare
|
Tested with RHEL AI 3.4.0-ea.1, I squashed commits and rebased |
| Accelerator string | ||
| Version string | ||
| CustomAMI string | ||
| CustomImage string |
There was a problem hiding this comment.
Ohh a s this is an API..we should decide in one arg name which will work for AMI in AWS and Image in Azure...you can leave CustomImageName or CustomVersion but only one which then will be translated to the right name for the provider
There was a problem hiding this comment.
Updated but not tested yet
There was a problem hiding this comment.
Tested with both AWS and Azure
|
Can you also check if the new azure naming is valid here? I mean |
Why would that be a problem? This is for custom image which can be anything (we already use strings like |
|
NVM I meant to test not with custom but with version, but that should be a different PR, I guess it works as it works for AWS and versions are treated the same |
ppitonak
force-pushed
the
azure_custom_image
branch
from
8dc9f14 to
17cf279
Compare
|
@ppitonak I do not see any change in azue tekton task? is if fine? |
Flag custom-ami (AWS-specific name) renamed to custom-image (more neutral) in both AWS and Azure. The flag was completely ignored, it was always searching for 3.0.0 Signed-off-by: Pavol Pitonak <ppitonak@redhat.com>
ppitonak
force-pushed
the
azure_custom_image
branch
from
17cf279 to
fdc0337
Compare
|
@adrianriobo you are right. I somehow missed Azure Tekton task, fixed now |
2 participants
Flag custom-ami (AWS-specific name) renamed to custom-image (more neutral). The flag was completely ignored, it always was searching for 3.0.0