Update to latest commit of argo-rollouts-manager '1824164aac67c5eb8e331238ec9f602809537ab4' and argocd-operator '0433a07294f89d858bc88192f9b96155985cec46'#1082
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4acdd5b to
746b536
Compare
/retest |
|
/retest |
ranakan19
left a comment
There was a problem hiding this comment.
I was able to verify sha256 value of metric-plugin-linux-amd64. I do see a difference from argoproj-labs/argo-rollouts-manager@1824164 as rollouts-manager is still using v0.0.3.
So my only question is around the different sha format. My guess is we were previously using a sha1 format even when the field was called sha256 are now getting to correct it. However if thats not the case, I'm curious to know more.
| Name: "argoproj-labs/sample-prometheus", | ||
| Location: "https://github.com/argoproj-labs/sample-rollouts-metric-plugin/releases/download/v0.0.4/metric-plugin-linux-amd64", | ||
| SHA256: "dac10cbf57633c9832a17f8c27d2ca34aa97dd3d", | ||
| SHA256: "af83581a496cebad569c6ddca4e1b7beef1c6f51573d6cd235cebe4390d3a767", |
There was a problem hiding this comment.
different sha length here stands out to me, is this intentional?
also the sha is different from argoproj-labs/argo-rollouts-manager@1824164
There was a problem hiding this comment.
The old value was invalid (it's not even the right length for sha256 😅 ), but because the argo rollouts manager code wasn't properly applying the SHA to the ConfigMap, it wasn't caught by the test.
The current value is the new, correct value; you can verify manually by downloading the binary and running sha256sum "(downloaded binary from url)" (IIRC sha256sum only works on Linux, but mac os has an equivalent)
| - name: argoproj-labs/sample-prometheus | ||
| location: https://github.com/argoproj-labs/sample-rollouts-metric-plugin/releases/download/v0.0.4/metric-plugin-linux-amd64 | ||
| sha256: dac10cbf57633c9832a17f8c27d2ca34aa97dd3d`)) | ||
| sha256: af83581a496cebad569c6ddca4e1b7beef1c6f51573d6cd235cebe4390d3a767`)) |
There was a problem hiding this comment.
Yup, same as above, the new value is the actual correct value (no idea what the provenance of the old value was)
My strategy for rollouts-manager is we first ship a particular commit downstream (in this case, This avoids the issue where this happens, for example:
It would have been less churn if one had just waited for downstream testing to complete before creating the GitHub release. An example of exactly this recently was argocd-agent made it to v0.5.3 (starting at v0.5.0) as we kept needing fixes in upstream library (argocd-agent) due to finding issues via QE testing downstream. I'm not sure if this is exactly the orthodox approach, but it makes sense to me 😁 |
…31238ec9f602809537ab4' Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
746b536 to
03d5007
Compare
Signed-off-by: Jonathan West <jgwest@gmail.com>
46bc6d9 to
8cc13c9
Compare
|
@jgwest: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Merging as v4.14 tests are still failing due to external rate limiting. |
Update to most recent 'argo-rollouts-manager' commit: argoproj-labs/argo-rollouts-manager@1824164 and 'argocd-operator' 0433a07294f89d858bc88192f9b96155985cec46