Skip to content

Update to latest commit of argo-rollouts-manager '1824164aac67c5eb8e331238ec9f602809537ab4' and argocd-operator '0433a07294f89d858bc88192f9b96155985cec46'#1082

Merged
jgwest merged 3 commits intoredhat-developer:masterfrom
jgwest:upgrade-rollouts-manager
Mar 2, 2026
Merged

Update to latest commit of argo-rollouts-manager '1824164aac67c5eb8e331238ec9f602809537ab4' and argocd-operator '0433a07294f89d858bc88192f9b96155985cec46'#1082
jgwest merged 3 commits intoredhat-developer:masterfrom
jgwest:upgrade-rollouts-manager

Conversation

@jgwest
Copy link
Member

@jgwest jgwest commented Feb 24, 2026

Update to most recent 'argo-rollouts-manager' commit: argoproj-labs/argo-rollouts-manager@1824164 and 'argocd-operator' 0433a07294f89d858bc88192f9b96155985cec46

@openshift-ci openshift-ci bot requested a review from chetan-rns February 24, 2026 12:25
@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jopit for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from trdoyle81 February 24, 2026 12:25
@jgwest jgwest force-pushed the upgrade-rollouts-manager branch from 4acdd5b to 746b536 Compare February 25, 2026 11:21
@jgwest
Copy link
Member Author

jgwest commented Feb 25, 2026

�[36mINFO�[0m[2026-02-25T11:26:34Z] Acquiring leases for test kuttl-sequential: [gitops-aws-quota-slice] 
�[31mERRO�[0m[2026-02-25T13:26:34Z] error: Failed to acquire resource, current capacity: 0 free, 10 leased 
�[36mINFO�[0m[2026-02-25T13:26:34Z] Ran for 2h4m27s                              
�[31mERRO�[0m[2026-02-25T13:26:34Z] Some steps failed:                           
�[31mERRO�[0m[2026-02-25T13:26:34Z] 
  * could not run steps: step kuttl-sequential failed: failed to acquire lease for "gitops-aws-quota-slice": resources not found 
�[36mINFO�[0m[2026-02-25T13:26:34Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:utilizing_lease:acquiring_lease' 

/retest

@jgwest
Copy link
Member Author

jgwest commented Feb 26, 2026

/retest

Copy link

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to verify sha256 value of metric-plugin-linux-amd64. I do see a difference from argoproj-labs/argo-rollouts-manager@1824164 as rollouts-manager is still using v0.0.3.
So my only question is around the different sha format. My guess is we were previously using a sha1 format even when the field was called sha256 are now getting to correct it. However if thats not the case, I'm curious to know more.

Name: "argoproj-labs/sample-prometheus",
Location: "https://github.com/argoproj-labs/sample-rollouts-metric-plugin/releases/download/v0.0.4/metric-plugin-linux-amd64",
SHA256: "dac10cbf57633c9832a17f8c27d2ca34aa97dd3d",
SHA256: "af83581a496cebad569c6ddca4e1b7beef1c6f51573d6cd235cebe4390d3a767",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different sha length here stands out to me, is this intentional?
also the sha is different from argoproj-labs/argo-rollouts-manager@1824164

Copy link
Member Author

@jgwest jgwest Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old value was invalid (it's not even the right length for sha256 😅 ), but because the argo rollouts manager code wasn't properly applying the SHA to the ConfigMap, it wasn't caught by the test.

The current value is the new, correct value; you can verify manually by downloading the binary and running sha256sum "(downloaded binary from url)" (IIRC sha256sum only works on Linux, but mac os has an equivalent)

- name: argoproj-labs/sample-prometheus
location: https://github.com/argoproj-labs/sample-rollouts-metric-plugin/releases/download/v0.0.4/metric-plugin-linux-amd64
sha256: dac10cbf57633c9832a17f8c27d2ca34aa97dd3d`))
sha256: af83581a496cebad569c6ddca4e1b7beef1c6f51573d6cd235cebe4390d3a767`))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, same as above, the new value is the actual correct value (no idea what the provenance of the old value was)

Copy link

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found my answers here and here - hopefully it helps someone else reviewing it later, so leaving them here. LGTM otherwise

side note:
I was looking for rollouts-manager release note for v0.0.8 to see if migration of cm key is mentioned, but did not see the release, am i missing something?

@jgwest
Copy link
Member Author

jgwest commented Feb 26, 2026

I was looking for rollouts-manager release note for v0.0.8 to see if migration of cm key is mentioned, but did not see the release, am i missing something?

My strategy for rollouts-manager is we first ship a particular commit downstream (in this case, 1824164aac67c5eb8e331238ec9f602809537ab4), and once that release has shipped, THEN I create the GitHub release and tag. So you will see the proper GitHub release of argo-rollouts-manager shortly after downstream product is out.

This avoids the issue where this happens, for example:

  1. You want to consume a library v1.0 via a downstream product, so you create a v1.0 release for the library
  2. You find a bug in v1.0 after some testing the library with downstream product during QE testing.
  3. You fix the bug and create a v1.0.1.
  4. You find another bug during QE testing via the downstream product.
  5. You fix the bug and create a v1.0.2.
    etc.

It would have been less churn if one had just waited for downstream testing to complete before creating the GitHub release.

An example of exactly this recently was argocd-agent made it to v0.5.3 (starting at v0.5.0) as we kept needing fixes in upstream library (argocd-agent) due to finding issues via QE testing downstream.

I'm not sure if this is exactly the orthodox approach, but it makes sense to me 😁

…31238ec9f602809537ab4'

Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
@jgwest jgwest force-pushed the upgrade-rollouts-manager branch from 746b536 to 03d5007 Compare February 27, 2026 07:35
@jgwest jgwest changed the title Update to latest commit of argo-rollouts-manager '1824164aac67c5eb8e331238ec9f602809537ab4' Update to latest commit of argo-rollouts-manager '1824164aac67c5eb8e331238ec9f602809537ab4' and argocd-operator '8b5b17571940e7dec464e05dd8d17a0a6c12eea0' Feb 27, 2026
Signed-off-by: Jonathan West <jgwest@gmail.com>
@jgwest jgwest force-pushed the upgrade-rollouts-manager branch from 46bc6d9 to 8cc13c9 Compare February 27, 2026 08:27
@jgwest jgwest changed the title Update to latest commit of argo-rollouts-manager '1824164aac67c5eb8e331238ec9f602809537ab4' and argocd-operator '8b5b17571940e7dec464e05dd8d17a0a6c12eea0' Update to latest commit of argo-rollouts-manager '1824164aac67c5eb8e331238ec9f602809537ab4' and argocd-operator '0433a07294f89d858bc88192f9b96155985cec46' Feb 27, 2026
Copy link
Member

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

@jgwest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-parallel 8cc13c9 link false /test v4.14-kuttl-parallel
ci/prow/v4.14-e2e 8cc13c9 link true /test v4.14-e2e
ci/prow/v4.14-kuttl-sequential 8cc13c9 link false /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgwest
Copy link
Member Author

jgwest commented Mar 2, 2026

Merging as v4.14 tests are still failing due to external rate limiting.

@jgwest jgwest merged commit 9a57715 into redhat-developer:master Mar 2, 2026
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants