Adding a query param class for each operation instead of sharing a single class for all operations#321
Open
douglasmiller wants to merge 1 commit intov3-v2021-02-25from
Open
Adding a query param class for each operation instead of sharing a single class for all operations#321douglasmiller wants to merge 1 commit intov3-v2021-02-25from
douglasmiller wants to merge 1 commit intov3-v2021-02-25from
Conversation
single class for all operations
douglasmiller
force-pushed
the
operation-params
branch
from
8cc45b7 to
b74af64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there was a single
QueryParamsclass that included setter method for all possible query parameters that could be used across all API requests. This has shown to be inadequate when multiple API requests use the same query parameter name with different values/types.This update removes the
QueryParamsclass in favor of anAbstractQueryParamsclass that can be extended for each individual API request method.Addresses #306