Skip to content

[type-declaration] Add ReturnIteratorInDataProviderRector#7593

Merged
TomasVotruba merged 1 commit intomainfrom
tv-iterator-data-provider
Oct 27, 2025
Merged

[type-declaration] Add ReturnIteratorInDataProviderRector#7593
TomasVotruba merged 1 commit intomainfrom
tv-iterator-data-provider

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

No description provided.

@TomasVotruba TomasVotruba merged commit 8654b74 into main Oct 27, 2025
53 checks passed
@TomasVotruba TomasVotruba deleted the tv-iterator-data-provider branch October 27, 2025 20:59
@clxmstaab
Copy link
Copy Markdown
Contributor

clxmstaab commented Oct 30, 2025

just fyi, in case you plan to work on adding a precise return-phpdoc via rector to data-provider methods.

starting with the next phpstan-phpunit release, PHPStan will no longer error about missingType.iterableValue on data-provider methods (because we start validating the data-sets of a dataprovider against the test-signature)

See phpstan/phpstan-phpunit#246

@TomasVotruba
Copy link
Copy Markdown
Member Author

@clxmstaab That's great news! I've scratching my head, why this is need ever since I saw this error :D

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants