Don't try to get phone account if self managed when creating a connection#685
Open
donaldkwong wants to merge 3 commits intoreact-native-webrtc:masterfrom
Open
Don't try to get phone account if self managed when creating a connection#685donaldkwong wants to merge 3 commits intoreact-native-webrtc:masterfrom
donaldkwong wants to merge 3 commits intoreact-native-webrtc:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to use CallKeep without requesting READ_PHONE_STATE permissions on Android, which should be possible if we're in self managed state. However, the connection creation code in
VoiceConnectionServicealways tries to get the phone account, which requires that permission to be granted. This diff adds a check to see if we're in self managed mode and, if so, don't try to get the phone account.