Enhanced Disk Usage 1.0.1 - fixed middle click to open new file explorer windows, reordered settings for better flow#3969
Enhanced Disk Usage 1.0.1 - fixed middle click to open new file explorer windows, reordered settings for better flow#3969bbmaster123 wants to merge 21 commits into
Conversation
Refactor code for readability and maintainability, including consistent formatting and improved comments.
- added suggestions regarding threading, context etc - fixed rendering issues in views other than tile view - fixed other areas of explorer being affected such as date modified column in details view when browsing other folders - multilingual support, supposedly (gemeni generated, needs testing) - added track height/width settings (inset) - fixed border thickness when set to 0 - ellipsis toggle for adding ... at the end of a word when text is too long - multi-line support via \n with line-height adjustment - progress bar vertical offset - removed bold segment offset as no longer needed - covering all bases as best as possible, still bug hunting. small bugs may still remain, but being tested and worked on.
- added explorer refresh on init/uninit/change settings - fixed disk bars losing styling when not active window - does not style properties window disk usage (pie chart or disk bar using mod) as that is classed as a button, and enabling that would style all buttons. might be interesting for a button styler mod though!
file names such as 4M2M.txt no longer display as false disk usage stats
Updated descriptions and names to improve clarity and consistency. Adjusted format string and added validation for unit strings.
- Fixed typos, window check, return correct ProcAddress - Add new settings for track border offset and fill padding - added toggle for only rounding left side/both sides
because I messed up copy/paste again. you'd think after all these years I wouldn't keep making that mistake, but here we are!
- previously, if "launch folder windows in a separate process" was not enabled, middle clicking on file explorer on the taskbar wouldn't open a new instance as expected. This resolves that issue - rearranged settings so that they flow from progress bar colors to bar geometry to track to border to text in that order, which should be a bit nicer overall
|
wait 18 commits? I thought I was just trying to merge the 2 commits I made...did I mess up? |
|
It's fine as long as what you see in the "Files changed" tab is correct. |
|
sorry I'll work on it a bit more and resubmit... |
|
Sure, let me know when it's ready. |
1px should = 1px, not (1px * scale)
|
@m417z |
did I even paste at all? ok sorry I feel dumb now
Why? I think using (1px * scale) is more helpful. For example, if somebody uses multiple monitors with different DPIs (scales), using (1px * scale) will yield a similar result in all monitors, while not taking scale into account will make the corner radius and other sizes look different. |
|
@m417z As an alternative, I can revert this change and instead add a custom scale factor setting, or probably more simple to just have finer grained border controls, which should give pretty much the same effect. |
I think that's the simplest solution, e.g. you can allow to configure quarters of pixels, so a value of 12 will mean 3px on 100% DPI. |
2 participants
Changelog
If the submission is an update to an existing mod, include the changelog below:
Mod authorship
If the submission is a new mod, please fill the form below.
This mod was created by:
Please select the appropriate option. Your selection will not affect acceptance criteria, but will help reviewers understand the context of the code and provide relevant feedback.
middle click to open new file explorer windows wasn't working when "launch folder windows in a separate process" was not enabled. I usually have it enabled so I hadn't caught it until now. This update changes the way windows are refreshed, which avoids a deadlock in that situation.
I've also reordered the settings to flow better/grouped together which I think makes it a bit better overall.