Skip to content

Fix velocity command obstacle params handling#194

Merged
khughes-bdai merged 1 commit into
rai-opensource:mainfrom
DipFlip:codex/fix-body-height-obstacle-params
Mar 25, 2026
Merged

Fix velocity command obstacle params handling#194
khughes-bdai merged 1 commit into
rai-opensource:mainfrom
DipFlip:codex/fix-body-height-obstacle-params

Conversation

@DipFlip
Copy link
Copy Markdown
Contributor

@DipFlip DipFlip commented Mar 13, 2026

Fixes #192

Now the body_height and use_obstacle_params are not intertvined.

@khughes-bdai
Copy link
Copy Markdown
Contributor

Thanks for the PR! The changes look good to me, I'll test it out on one of our robots to verify the behavior. Before merging, would you mind updating your branch to pass the pre-commit check? (pre-commit install then pre-commit run --all)

@DipFlip DipFlip force-pushed the codex/fix-body-height-obstacle-params branch from 19e6bf7 to 915db2f Compare March 23, 2026 19:37
@DipFlip
Copy link
Copy Markdown
Contributor Author

DipFlip commented Mar 23, 2026

Thanks @khughes-bdai . The pre-commit change is pushed now

Copy link
Copy Markdown
Contributor

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Copy Markdown
Contributor

khughes-bdai commented Mar 25, 2026

Merge activity

  • Mar 25, 9:03 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 25, 9:03 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (Fast-forward merges are not supported for forked repositories. Please create a branch in the target repository in order to merge).

@khughes-bdai khughes-bdai merged commit 10758f2 into rai-opensource:main Mar 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting body_height disables obstacle_params

2 participants