Open
Conversation
guilload
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When deploying the new IngesterStatus broadcast, old ingesters dont broadcast their status, which causes the control plane running the new code to only see the ingesters running the new code as
Ready. This causes all of the shards on the cluster to be placed on only new ingesters, which breaks the cluster. This self-resolves once the deployment is complete.This change results in the same behavior as today - if a node doesn't broadcast an ingester status, we assume it's Ready, which is what we did before. This should fix deploys.
How was this PR tested?
Tested that ingester status unwraps correctly and on a test cluster.