Conversation
a9b38fb to
32a8e64
Compare
|
@rdettai-sk Merging your PR in this. Claude made it in a different PR for the rebase. (I hardocded you as the author the author so you get the github stats and street cred. ( |
Rebase of #5957 by @rdettai-sk onto main, updated to use the latest tantivy revision (545169c0d8) which includes composite aggregation support upstream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
32a8e64 to
2914a35
Compare
rdettai-sk
left a comment
There was a problem hiding this comment.
thanks @fulmicoton!
The tests are failing because I have updated tantivy in between to have a safer pagination: just relying on json types is not enough to fully represent all possible page positions inside quickwit fastfield column types. Ideally we should not assert on the pagination key value as it is supposed to be opaque according to the ES spec, but I found it convenient to have a clear test that showcases the behavior here.
| host: "192.168.0.10" | ||
| name: "Albert" | ||
| response: 100.0 |
There was a problem hiding this comment.
| host: "192.168.0.10" | |
| name: "Albert" | |
| response: 100.0 | |
| host: "str:192.168.0.10" | |
| name: "str:Albert" | |
| response: "f64:100" |
| host: "192.168.0.10" | ||
| name: "Albert" | ||
| response: 100.0 |
There was a problem hiding this comment.
| host: "192.168.0.10" | |
| name: "Albert" | |
| response: 100.0 | |
| host: "str:192.168.0.10" | |
| name: "str:Albert" | |
| response: "f64:100" |
f79d2b5 to
1ffd63e
Compare
1ffd63e to
54a6f98
Compare
Summary
545169c0d8) which includes composite aggregation support upstreamquickwit-queryaggregation mappingsSend+Syncconstraint incontrolled_directory.rsfor the updated tantivy APITest plan
cargo checkpassescargo nextest run -p quickwit-query— 139 tests passcargo nextest run -p quickwit-indexing— 165 tests passcargo nextest run -p quickwit-search— 159 tests pass🤖 Generated with Claude Code