Skip to content

Add check/all#1146

Merged
mhucka merged 16 commits intomainfrom
mh-add-check-all
Mar 13, 2026
Merged

Add check/all#1146
mhucka merged 16 commits intomainfrom
mh-add-check-all

Conversation

@mhucka
Copy link
Copy Markdown
Contributor

@mhucka mhucka commented Sep 26, 2025

This is adapted from, but heavily modified from, Cirq's check/all.

This is adapted from, but heavily modified from, Cirq's check/all.
@mhucka mhucka marked this pull request as ready for review September 26, 2025 20:40
Copy link
Copy Markdown
Contributor

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unplugged --no-coverage from the usage doc. Also see inline comments for more suggestions.

Comment thread check/all Outdated
Comment thread check/all Outdated
Comment thread check/all Outdated
Comment thread check/all Outdated
Comment thread check/all Outdated
Comment thread check/all Outdated
Comment thread check/all Outdated
Comment thread check/all Outdated
@mhucka
Copy link
Copy Markdown
Contributor Author

mhucka commented Mar 12, 2026

@pavoljuhas All the changes done. Thanks for the detailed improvements!

@mhucka mhucka requested a review from pavoljuhas March 13, 2026 20:35
@mhucka mhucka added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit 4d66bf3 Mar 13, 2026
25 checks passed
@mhucka mhucka deleted the mh-add-check-all branch March 13, 2026 22:45
pavoljuhas added a commit to pavoljuhas/Cirq that referenced this pull request Mar 19, 2026
* include the `ruff check` linter check

* add option `--fix` to apply corrections from both `ruff` and `black`

* add option `--changed` as a shorter alias for `--only-changed-files`

* support `-h, --help` to show usage info

* improve parsing of the BASE_REV revision argument

* skip check/doctest in the only-changed-files mode to make it fast

* rewrite in a similar way as in quantumlib/OpenFermion,
  ref: quantumlib/OpenFermion#1146

Follow-up to quantumlib#7951
github-merge-queue Bot pushed a commit to quantumlib/Cirq that referenced this pull request Mar 19, 2026
* include the `ruff check` linter check
* add option `--fix` to apply corrections from both `ruff` and `black`
* add option `--changed` as a shorter alias for `--only-changed-files`
* support `-h, --help` to show usage info
* improve parsing of the BASE_REV revision argument
* skip check/doctest in the only-changed-files mode to make it fast
* rewrite in a similar way as in quantumlib/OpenFermion,
  ref: quantumlib/OpenFermion#1146

Follow-up to #7951

---------

Co-authored-by: Michael Hucka <mhucka@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants