Warn when layout width/height is given but size_hint will override it#2834
Merged
eruvanos merged 4 commits intodevelopmentfrom Mar 11, 2026
Merged
Warn when layout width/height is given but size_hint will override it#2834eruvanos merged 4 commits intodevelopmentfrom
eruvanos merged 4 commits intodevelopmentfrom
Conversation
…cts with active size_hint Co-authored-by: eruvanos <9437863+eruvanos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add warning for missing size_hint in Arcade GUI layouts
Warn when layout width/height is given but size_hint will override it
Mar 10, 2026
eruvanos
requested changes
Mar 10, 2026
…atch_warnings in tests Co-authored-by: eruvanos <9437863+eruvanos@users.noreply.github.com>
eruvanos
reviewed
Mar 10, 2026
Co-authored-by: eruvanos <9437863+eruvanos@users.noreply.github.com>
eruvanos
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_NO_EXPLICIT_SIZEsentinel and_warn_if_size_hint_overrides_fixed_size()helper to layout.pysize_hint=Nonewhere they intentionally set fixed dimensions...(Ellipsis) instead ofobject()for the sentinel valuefloat | EllipsisTypetype hints forwidth/heightin all three layout init methodswarnings.catch_warnings()withsimplefilter("error")in "no warning" tests...sentinel directly (no named variable)_warn_if_size_hint_overrides_fixed_sizeto a method onUILayout🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.