Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
47b3f0d to
df3417c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
brianschubert
left a comment
There was a problem hiding this comment.
Adding the re-exports makes sense to me, but we shouldn't change __all__ on Python >=3.14 if these names are not present in __all__ at runtime. That would make tools incorrectly think that these names are imported by from asyncio import * when they are not.
(also, please try not to force push since that makes reviewing harder. In this case, seeing the stubtest errors from the earlier commits is actually really helpful)
|
@brianschubert Thanks for the review. I've updated the PR! Noted about force pushing (I thought I marked the PR as draft before doing that but evidently did not, sorry about the noise). For what it's worth, the changes weren't stubtest fixes and I didn't see any stubtest errors. |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AbstractEventLoopPolicy,DefaultEventLoopPolicy,WindowsSelectorEventLoopPolicycandWindowsProactorEventLoopPolicyare exported byasynciovia__getattr__in 3.14, but are missing from the stubs.https://github.com/python/cpython/blob/3.14/Lib/asyncio/__init__.py
The names were removed in #14128.