[mypyc] Update vec value struct to have direct pointer to items#21420
Open
[mypyc] Update vec value struct to have direct pointer to items#21420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the second field of a
vecstruct representation points to the first data item. Previously the second field of thevecstruct representation was aPyObject *targeting the buffer object. This removes one pointer addition per get item or set item operation. Since these are often the most performance critical operations, we want them to be as efficient as possible. This should reduce the number of instructions at least on ARM, and it will reduce code size on x64 as well.Since vec is still behind a feature flag, we can still break the ABI.
Used heavy coding agent assist, but iterated until the results look good.