gh-146589: Fix raw buffer merge in UnixConsole.getpending()#146590
Closed
cuiweixie wants to merge 1 commit intopython:mainfrom
Closed
gh-146589: Fix raw buffer merge in UnixConsole.getpending()#146590cuiweixie wants to merge 1 commit intopython:mainfrom
cuiweixie wants to merge 1 commit intopython:mainfrom
Conversation
When coalescing queued input events, append e2.raw to e.raw instead of duplicating e.raw (e.raw += e.raw was incorrect).
Member
|
Closing because we don't have a consensus yet in the original issue #145886. |
Member
|
In addition, don't use AI to generate PRs or we will restrict your access should this be overused. TiA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gh-146589.
When
getpending()merges consecutive events from the queue,e.rawwasupdated with
e.raw += e.rawinstead of appending the second event's bytes.Use
e.raw += e2.raw, consistent withe.data += e2.data.Test plan
relevant
_pyrepltests if present.