BUG: fix dirint KeyError with scalar inputs on pandas >= 2.0#2752
Open
Omesh37 wants to merge 6 commits intopvlib:mainfrom
Open
BUG: fix dirint KeyError with scalar inputs on pandas >= 2.0#2752Omesh37 wants to merge 6 commits intopvlib:mainfrom
Omesh37 wants to merge 6 commits intopvlib:mainfrom
Conversation
Contributor
Author
|
Updated the PR based on your feedback:
All 9 dirint tests pass locally. Please let me know if anything needs adjusting. |
RDaxini
reviewed
May 10, 2026
Member
RDaxini
left a comment
RDaxini
left a comment
There was a problem hiding this comment.
I don't think the test failure is related to the changes in this PR
Co-authored-by: Rajiv Daxini <143435106+RDaxini@users.noreply.github.com>
Co-authored-by: Rajiv Daxini <143435106+RDaxini@users.noreply.github.com>
Contributor
Author
Ya it is related to failing test of test_singlediode_precision function in test_singlediode.py. Thank You :) |
echedey-ls
approved these changes
May 10, 2026
Member
echedey-ls
left a comment
echedey-ls
left a comment
There was a problem hiding this comment.
Nice PR @Omesh37 . Two minor comments down below.
| dni : array-like | ||
| The modeled direct normal irradiance, as provided by the | ||
| DIRINT model. [Wm⁻²] | ||
| dni : numeric or pd.Series |
Member
There was a problem hiding this comment.
Suggested change
| dni : numeric or pd.Series | |
| dni : numeric |
pd.Series is considered numeric
https://pvlib-python.readthedocs.io/en/stable/contributing/style_guide.html#documentation-style
Comment on lines
+17
to
+18
| * Fixed :py:func:`pvlib.irradiance.dirint` raising ``KeyError`` with | ||
| scalar inputs on pandas >= 2.0. (:pull:`2752`, :issue:`2751`) |
Member
There was a problem hiding this comment.
Suggested change
| * Fixed :py:func:`pvlib.irradiance.dirint` raising ``KeyError`` with | |
| scalar inputs on pandas >= 2.0. (:pull:`2752`, :issue:`2751`) | |
| * Fix :py:func:`pvlib.irradiance.dirint` raises ``KeyError`` with | |
| scalar inputs on ``pandas>=2.0``. (:issue:`2751`, :pull:`2752`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2751
Description
pvlib.irradiance.dirintcrashed withKeyError: 'cannot use a single bool to index into setitem'when called with scalar inputs on pandas >= 2.0.In
_dirint_bins, scalar inputs likesolar_zenith=90cause comparisons such as(zenith >= 0) & (zenith < 25)to return a plain Pythonbool. pandas >= 2.0 treats scalar bools as label lookups onsetitem, raisingKeyError.Fix: Convert all four scalar-or-array inputs to
pd.Seriesat the top of_dirint_bins, ensuring boolean masks are always a booleanSeries.Checklist
docs/sphinx/source/whatsnew