Fix PVSystem module_type docstring default#2713
Open
r0hansaxena wants to merge 4 commits intopvlib:mainfrom
Open
Fix PVSystem module_type docstring default#2713r0hansaxena wants to merge 4 commits intopvlib:mainfrom
r0hansaxena wants to merge 4 commits intopvlib:mainfrom
Conversation
Updated issue and pull request references for clarity.
Member
|
Please, see #1574 |
cwhanse
approved these changes
Mar 9, 2026
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
echedey-ls
reviewed
Mar 9, 2026
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
RDaxini
suggested changes
Mar 10, 2026
Member
RDaxini
left a comment
RDaxini
left a comment
There was a problem hiding this comment.
the whatsnew entry now needs to be updated
Comment on lines
+41
to
+43
| * Correct :py:class:`pvlib.pvsystem.PVSystem` docstring to state that | ||
| ``module_type`` defaults to ``None``. | ||
| (:issue:`2634`, :pull:`2713`) |
Member
There was a problem hiding this comment.
Suggested change
| * Correct :py:class:`pvlib.pvsystem.PVSystem` docstring to state that | |
| ``module_type`` defaults to ``None``. | |
| (:issue:`2634`, :pull:`2713`) | |
| * Update :py:class:`pvlib.pvsystem.PVSystem` docstring to state that | |
| ``module_type`` is optional. | |
| (:issue:`2634`, :pull:`2713`) |
Member
|
@r0hansaxena thanks for your contribution. I did want to say though that I couldn't help but notice that the review/commit history here seems to suggest you did not review the comment from @echedey-ls #2713 (comment), which led to him having to make the change for you to commit. In future, it would be helpful to review all feedback thoroughly and act accordingly, to save everyone time and ensure we still get these important fixes pushed through efficiently. If you ever have questions about reviews or comments, you can always post a follow up comment to ask and clarify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The module_type parameter in PVSystem is documented as having a default value of 'glass_polymer', but the actual default is None. This PR corrects the docstring to reflect the actual default.