[SDK] Add host, wsPort, wssPort for configuration#161
Closed
bradleybernard wants to merge 1 commit intopusher:masterfrom
Closed
[SDK] Add host, wsPort, wssPort for configuration#161bradleybernard wants to merge 1 commit intopusher:masterfrom
bradleybernard wants to merge 1 commit intopusher:masterfrom
Conversation
|
there is a patch solution here, hopefully Pusher can merge that PR soon. |
Contributor
|
Closing as the host/wsPort/wssPort configuration support added in this PR has been superseded by #165, which has now been merged. Thanks for the contribution @bradleybernard! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both iOS and Android SDKs have
host,wsPortandwssPortbut RN SDK doesn't allow it. Expose it to RN world, so that configurations are the same!NOTE: No iOS changes since it takes in a generic dictionary and is handled already by native Swift SDK.