security: remove vulnerable Python 2 deps (pyopenssl, pyasn1, ndg-httpsclient)#251
Open
AhsanSheraz wants to merge 2 commits intopusher:masterfrom
Open
security: remove vulnerable Python 2 deps (pyopenssl, pyasn1, ndg-httpsclient)#251AhsanSheraz wants to merge 2 commits intopusher:masterfrom
AhsanSheraz wants to merge 2 commits intopusher:masterfrom
Conversation
…ndg-httpsclient These dependencies were only used for Python 2 SNI support (gated behind `sys.version_info < (3,)` in requests.py) and are unnecessary on Python 3, which handles SNI natively via the stdlib ssl module. Removes: - pyopenssl (CVE-2026-27459, fixed in 26.0.0) - pyasn1 (CVE-2026-30922, fixed in 0.6.3) - ndg-httpsclient (depends on both)
AhsanSheraz
force-pushed
the
security/remove-vulnerable-py2-deps
branch
from
e39b279 to
8463644
Compare
Remove pyopenssl (CVE-2026-27459), pyasn1 (CVE-2026-30922), and ndg-httpsclient from install_requires. These were only needed for Python 2 SNI support and are dead code on Python 3. - Remove Python 2 pyopenssl injection in pusher/requests.py - Remove 'Python :: 2' classifier from setup.py - Update README to note Python 2 is no longer supported Closes pusher#252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyopenssl(CVE-2026-27459),pyasn1(CVE-2026-30922), andndg-httpsclientfrominstall_requirespusher/requests.py(was gated behindsys.version_info < (3,))Python :: 2classifier fromsetup.py, addPython :: 3 :: OnlyThese dependencies were only needed for Python 2 SNI support. Python 3's stdlib
sslmodule handles SNI natively, making them unnecessary. The fixed versions of these libraries don't support Python 2 anyway, so upgrading is not an option — removal is the correct fix.See full rationale in #252.
Test plan
Closes #252