Open
Conversation
This fixes a bug where foreign data declarations fail to check when they depend on data declarations. Previously, the data declaration would have been checked later than the foreign data declaration, causing an error.
The bug manifests when two exported modules contain overlapping names. The previous representation assumed that we can merge names across qualified imports, generating errors for duplicates.
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Amp <amp@ampcode.com>
This updates the constraint checker to properly consider kind arguments. This surfaced issues in compiler-constructed constraint applications that were missing kind arguments. Class member instantiation has also been updated to use kind arguments from instance declarations rather than create fresh unification variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this branch is to be able to compile the core packages; the
compiler-compatbilitycrate provides a utility that shows compilation errors for each module in the package. There's still a very long journey ahead.